Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: default editor's toc supports showing empty states #864

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 20, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

默认编辑器的大纲在没有内容的时候支持显示空状态的提示。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3335

Screenshots:

image

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Console 端默认编辑器的大纲列表支持显示空状态

@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 3:28AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 20, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Feb 20, 2023
@wan92hen
Copy link
Contributor

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 2705fc3 into halo-dev:main Feb 20, 2023
@ruibaby ruibaby deleted the perf/default-toc-empty branch February 20, 2023 07:26
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 20, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…nsole#864)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

默认编辑器的大纲在没有内容的时候支持显示空状态的提示。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3335

#### Screenshots:

<img width="1420" alt="image" src="https://user-images.githubusercontent.com/21301288/220002675-e16829f0-1c33-4030-a76b-4720dc7d7a69.png">

#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

```release-note
Console 端默认编辑器的大纲列表支持显示空状态
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端默认编辑器右侧大纲建议加入空状态
3 participants