This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
perf: improve error message of login #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
the
kind/improvement
|
@halo-dev/sig-halo-console |
JohnNiang
approved these changes
Feb 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/lgtm |
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 改进登录异常的提示信息，目前大致分为三种： 1. 用户名或密码错误 2. 跨域或网络请求异常 3. CSRF Token 失效 #### Which issue(s) this PR fixes: Fixes halo-dev#3291 #### Screenshots: <img width="1402" alt="image" src="https://user-images.githubusercontent.com/21301288/218319203-19517ab7-7740-41f9-8579-f10a60aa6e51.png"> <img width="1673" alt="image" src="https://user-images.githubusercontent.com/21301288/218319221-2fc332f4-4de7-4417-a277-0c4a396d6389.png"> #### Special notes for your reviewer: 测试方式： 1. 进入浏览器控制台清理 Cookie，以测试 CSRF Token 失效的情况。 2. 使用 3000 端口访问 Console，以测试跨域的情况。 3. 观察以上两种情况的登录请求异常提示信息是否符合要求。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端登录请求异常的提示 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
改进登录异常的提示信息，目前大致分为三种：
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3291
Screenshots:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?