Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: hide anonymousUser in user management list #844

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 10, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

在用户管理列表隐藏 anonymousUser 用户,anonymousUser 暂时没有实际用途。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2775 (comment)

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. 进入 Console 的用户管理,检查是否有名为 Anonymous User 的用户即可。

Does this PR introduce a user-facing change?

在 Console 端的用户管理中隐藏 `Anonymous User` 用户。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 10, 2023
@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 3:59AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Feb 10, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 7320aa1 into halo-dev:main Feb 10, 2023
@ruibaby ruibaby deleted the perf/hide-anonymousUser branch February 10, 2023 04:49
@ruibaby
Copy link
Member Author

ruibaby commented Feb 10, 2023

/cherrypick release-2.2

@halo-dev-bot
Copy link

@ruibaby: new pull request created: #846

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 10, 2023
This is an automated cherry-pick of #844

/assign ruibaby

```release-note
在 Console 端的用户管理中隐藏 `Anonymous User` 用户。
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 10, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

在用户管理列表隐藏 anonymousUser 用户,anonymousUser 暂时没有实际用途。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2775 (comment)

#### Screenshots:

<img width="1410" alt="image" src="https://user-images.githubusercontent.com/21301288/217997078-5e2e0724-5f22-45dc-a9c6-ee42254c9bd7.png">


#### Special notes for your reviewer:

测试方式:

1. 进入 Console 的用户管理,检查是否有名为 Anonymous User 的用户即可。

#### Does this PR introduce a user-facing change?

```release-note
在 Console 端的用户管理中隐藏 `Anonymous User` 用户。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

匿名用户需要限制部分编辑功能
4 participants