This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
feat: add supports for preview audio and video file in attachment detail #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@halo-dev/sig-halo-console |
JohnNiang
approved these changes
Feb 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/lgtm |
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…ail (halo-dev/console#841) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 支持在附件库的附件详情弹框中预览音视频文件。 #### Which issue(s) this PR fixes: Fixes halo-dev#1923 #### Screenshots: <img width="1011" alt="image" src="https://user-images.githubusercontent.com/21301288/217746883-92c46d4e-a51d-4b53-ae8e-f647a47b216f.png"> <img width="1010" alt="image" src="https://user-images.githubusercontent.com/21301288/217746922-9b014974-71aa-4d54-aa42-be2ae03647a1.png"> #### Special notes for your reviewer: 测试方式： 1. 上传若干视频和音频文件，检查是否可以正常播放即可。 可供测试的文件：[音视频测试.zip](https://github.com/halo-dev/console/files/10694553/default.zip) #### Does this PR introduce a user-facing change? ```release-note Console 端的附件详情支持预览音视频文件。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
支持在附件库的附件详情弹框中预览音视频文件。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#1923
Screenshots:
Special notes for your reviewer:
测试方式：
可供测试的文件：音视频测试.zip
Does this PR introduce a user-facing change?