This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 485
perf: improve usage of the card component in some pages #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
Categorizes issue or PR as related to a improvement.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
labels
Feb 7, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JohnNiang
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It works very well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 8, 2023
guqing
reviewed
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…sole#839) #### What type of PR is this? /kind improvement #### What this PR does / why we need it: 优化部分页面 VCard 组件的用法,修复样式问题。 #### Which issue(s) this PR fixes: Fixes halo-dev#3226 #### Screenshots: before: <img width="1417" alt="image" src="https://user-images.githubusercontent.com/21301288/217179383-d1dff4f5-4350-4881-aed6-c6bf2cc184c5.png"> after: <img width="1430" alt="image" src="https://user-images.githubusercontent.com/21301288/217179173-f61cf787-f34f-43a3-88c3-08fac6c31879.png"> #### Special notes for your reviewer: 测试方式: 1. 检查主题详情页面、插件详情页面、系统设置页面的内容区域,底部的圆角是否生效。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端主题详情、插件详情、系统设置中卡片组件的样式。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/improvement
Categorizes issue or PR as related to a improvement.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
优化部分页面 VCard 组件的用法,修复样式问题。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3226
Screenshots:
before:
after:
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?