Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: improve usage of the card component in some pages #839

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 7, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

优化部分页面 VCard 组件的用法,修复样式问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3226

Screenshots:

before:

image

after:

image

Special notes for your reviewer:

测试方式:

  1. 检查主题详情页面、插件详情页面、系统设置页面的内容区域,底部的圆角是否生效。

Does this PR introduce a user-facing change?

优化 Console 端主题详情、插件详情、系统设置中卡片组件的样式。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 7, 2023
@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 9:44AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

It works very well.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit b83d3e4 into halo-dev:main Feb 8, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 10, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…sole#839)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化部分页面 VCard 组件的用法,修复样式问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3226

#### Screenshots:

before:

<img width="1417" alt="image" src="https://user-images.githubusercontent.com/21301288/217179383-d1dff4f5-4350-4881-aed6-c6bf2cc184c5.png">

after:

<img width="1430" alt="image" src="https://user-images.githubusercontent.com/21301288/217179173-f61cf787-f34f-43a3-88c3-08fac6c31879.png">

#### Special notes for your reviewer:

测试方式:

1. 检查主题详情页面、插件详情页面、系统设置页面的内容区域,底部的圆角是否生效。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端主题详情、插件详情、系统设置中卡片组件的样式。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端的系统设置、主题管理、插件详情页面的 VCard 组件使用错误
3 participants