Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore: bump @halo-dev/editor to resolve duplicate rendering issue #562

Merged
merged 1 commit into from
May 8, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 7, 2022

halo-dev/editorhalo-dev/editor@cac614b 提交中修复了重复初始化 codemirror 的问题。

fixes halo-dev/halo#1906

/kind bug
/cc @halo-dev/sig-halo-admin
/milestone 1.5.x

Signed-off-by: Ryan Wang [email protected]

@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG May 7, 2022 09:56
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label May 7, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 1.5.x milestone May 7, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from ruibaby after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby
Copy link
Member Author

ruibaby commented May 7, 2022

/cherrypick release-1.5

@halo-dev-bot
Copy link

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit e973233 into halo-dev:master May 8, 2022
@ruibaby
Copy link
Member Author

ruibaby commented May 8, 2022

/cherrypick release-1.5

@halo-dev-bot
Copy link

@ruibaby: new pull request created: #563

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot
Copy link

@ruibaby: new pull request could not be created: failed to create pull request against halo-dev/halo-admin#release-1.5 from head halo-dev-bot:cherry-pick-562-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for halo-dev-bot:cherry-pick-562-to-release-1.5."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby deleted the chore/bump-editor-version branch May 9, 2022 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

halo后台编辑文章区域出现两个
4 participants