Conversation
Owner
hallipr
commented
Mar 15, 2024
hallipr
commented
- Add convenience methods for image edits and variations (Add convenience methods for image edits and variations joseharriaga/openai-in-typespec#11)
- Update chat's function calling sample (Update chat's function calling sample in README joseharriaga/openai-in-typespec#14)
- Temporarily rename FineTuningClient for codegen (Temporarily rename FineTuningClient for codegen joseharriaga/openai-in-typespec#15)
- migrate to int instead of long on custom surface (Use 'int' instead of 'long' on custom surface joseharriaga/openai-in-typespec#16)
- Add client builds to the main workflow (Add client builds to the main workflow joseharriaga/openai-in-typespec#12)
- Update generated OpenAPIv3 spec (Update generated OpenAPIv3 spec joseharriaga/openai-in-typespec#18)
- Add version properties to allow for action based package naming (Add version properties to allow for action based package naming joseharriaga/openai-in-typespec#19)
- Remove validation job from workflow (Remove validation job from workflow joseharriaga/openai-in-typespec#20)
- Remove no-PR condition on package upload
Implement support for image edits and variations as convenience methods that do multipart/form-data.
Making sure that the README is up-to-date with the latest samples.
Due to our codegen workarounds, we cannot have a method with the following signature in the custom public `OpenAIClient` class: ```csharp public FineTuningClient GetFineTuningClient() ``` This is because we need codegen to generate a different method that happens to have this same signature in the generated internal `OpenAIClient` class. Because making the generated `OpenAIClient` class internal is part of post-codegen processing, codegen has no way to know that these two are not the same class, so it skips generating the method thinking it has been customized instead. For now, we rename the `FineTuningClient` to `FineTuningManagementClient` to avoid this conflict. We will be able to fix it once we have codegen customizations available.
* Add workflow actions for build, pack and test * Add strong name key * Add update-client script * Add assembly strong naming to Directory.Build.props * Use dev nuget feed
…harriaga#19) * Add version properties * Rename workflow to Build and Test
* Remove validation job from workflow * Move empty string to false result in ternary
hallipr
force-pushed
the
users/hallipr/workflow
branch
from
f13210c to
96d114b
Compare
hallipr
force-pushed
the
users/hallipr/workflow
branch
4 times, most recently
from
94e0552 to
25343df
Compare
hallipr
force-pushed
the
users/hallipr/workflow
branch
from
25343df to
4529252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.