enforce buffer_constraints size matches dimensions in Parameter ctor - #9312
Merged
alexreinking merged 1 commit intoAug 14, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9312 +/- ##
==========================================
+ Coverage 69.92% 69.94% +0.02%
==========================================
Files 258 258
Lines 78206 78209 +3
Branches 19036 19037 +1
==========================================
+ Hits 54684 54707 +23
+ Misses 17804 17803 -1
+ Partials 5718 5699 -19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
abadams
approved these changes
Aug 13, 2026
alexreinking
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buffer Parameter reconstruction constructor takes buffer_constraints verbatim but reads dimensions from a separate argument, so a serialized pipeline declaring more dimensions than it has constraints for leaves the vector shorter than dimensions(). check_dim_ok() only bounds a dimension index against dimensions(), so stride_constraint/min_constraint/extent_constraint (reached from AddImageChecks during lowering) then index buffer_constraints past its end and read adjacent heap memory as Expr handles. Require the sizes to agree in the constructor, the invariant every other Parameter constructor already maintains.
Checklist