Fix usage of lookupTarget in LLVM #8841
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Asking halidebuildbots for a review didn't seem to work. @alexreinking do you know what might be wrong with that approach? |
Contributor
Author
|
This is been validated in my other PR #8629 because I rebased it there: conclusion is that it seems to be insufficient. I'll push again here and we'll hopefully see buildbots going again at it. Buildbots were super slow over the weekend for some reason. I might have spammed a few (force) pushes in quick succession, and perhaps something got lost. |
mcourteaux
changed the title
mcourteaux
changed the title
alexreinking
approved these changes
Oct 19, 2025
Member
|
Some of the bots seem to be having trouble uploading packages. They aren't failing to upload, the uploads are just proceeding very slowly. I'm going to merge this to get other PRs unstuck since it seems likely only the one remaining bot would have a problem with this. |
alexreinking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using preprocessor
#ifdefs because CodeGen_Internal also doesn't, for the same call. It just passes the triple and it's fine.