Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake minimum version to 3.28 #8363

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

alexreinking
Copy link
Member

@alexreinking alexreinking commented Jul 31, 2024

This is in line with our policy to track the version included in the latest Ubuntu LTS. Version 24.04 LTS now includes CMake 3.28.

Merge after #8362

This is in line with our policy to track the
version included in the latest Ubuntu LTS.
Version 24.04 LTS now includes CMake 3.28.
@alexreinking alexreinking force-pushed the build/min-cmake-3.28 branch from d37a8f7 to 5653ca2 Compare July 31, 2024 14:48
@alexreinking
Copy link
Member Author

mac-arm-worker-1 hung on Metal again. Machine could need a reboot.

@alexreinking alexreinking merged commit 837308f into main Aug 1, 2024
15 of 16 checks passed
@alexreinking alexreinking deleted the build/min-cmake-3.28 branch August 1, 2024 13:42
@mcourteaux
Copy link
Contributor

This is annoying... Why bump it if it works?

@mcourteaux
Copy link
Contributor

FYI: LTS releases of Ubuntu are supposed to be supported for 5 years, not 4. So there is a one-year overlap between two successive LTS releases. Now, I'm supposedly on a supported system by Ubuntu LTS guidelines, but Halide disrespects the LTS lifecycle.

@alexreinking
Copy link
Member Author

alexreinking commented Aug 10, 2024

@mcourteaux - because it enables some significant build improvements that have started being realized over the subsequent PRs.

Also, pip install --user cmake works... everywhere? Upgrading is not an issue except in seriously broken environments.

@alexreinking
Copy link
Member Author

Now, I'm supposedly on a supported system by Ubuntu LTS guidelines, but Halide disrespects the LTS lifecycle.

Also, if you prefer systemwide installations, you can stay on your LTS and use either snap install cmake to get the latest or use Kitware's APT repo if you prefer APT.

@mcourteaux
Copy link
Contributor

Thanks for the tips. I have no problem installing from source, it's just an annoying step. I should reinstall my system and switch from Ubuntu to Fedora either way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants