-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Dark colorscheme for Stmt HTML. Ability to programmatically export conceptual stmt files. #8327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to reject this, but let the record show that IMHO a light color scheme is preferable to a dark one; is there a way to have this say "prefer the system setting"?
/** Write out a conceptual representation of lowered code, before any parallel loop | ||
* get factored out into separate functions, or GPU loops are offloaded to kernel code.r | ||
* Useful for analyzing and debugging scheduling. Can emit html or plain text. */ | ||
void compile_to_conceptual_stmt(const std::string &filename, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new API call should be added to the Python bindings as well
It follows your system preferences. It's one of those CSS media queries. You'll see in the diff. |
Can it be made into a checkbox that either enables or disables dark mode? It can use the system preference by default, but I don't want to have to change my whole system preference just to get the page to switch palates. |
Fair request; working on it. |
Updated: added a toolbar with various settings. Browser persists those settings automatically (no cookie stuff). Color theme can be set to auto, or manual modes. Auto mode also live switches with the system preferences. @alexreinking @steven-johnson See video. stmt-html.small.mp4@steven-johnson Added those python bindings AFAICT. Not tested that tho. Just a copy-paste-and-modify. |
Looks great! |
@steven-johnson Did this OSX buildbot fail twice on exactly the same test? This thing doesn't seem to fail on other things? It's surprising that this PR would be related but I'm not ruling anything out here. Do you have more knowledge on this failure? Please see #8332 regarding this as well. |
Not sure, let's retry again |
Failure does seem unrelated...
Can this be merged, or should something change? |
@steven-johnson Can you have a look if this is okay? Side question: I'm guessing many folks are taking vacations and activity here is lower because of that? |
Colorscheme based on gruvbox-material.
stmt-html.small.mp4
Also improved assembly syntax highlighting (while reducing one HTTP fetch, as the highlight rules are now embedded in the generated file.).