Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OpenGLCompute for Halide 16 #7627

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

shoaibkamil
Copy link
Contributor

This marks OpenGLCompute as deprecated, roughly modeled after the commit that did the same for OpenGL.

@shoaibkamil shoaibkamil added the release_notes For changes that may warrant a note in README for official releases. label Jun 12, 2023
Copy link
Contributor

@derek-gerstmann derek-gerstmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@derek-gerstmann
Copy link
Contributor

Okay to merge?

@steven-johnson
Copy link
Contributor

LGTM

@derek-gerstmann derek-gerstmann merged commit 932ad0b into main Jun 14, 2023
@steven-johnson
Copy link
Contributor

steven-johnson commented Jun 20, 2023

Actually, I think there are Python usages that need deprecating too, I'll follow up

EDIT: actually, I think the python usages are ok for now

ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
* Deprecate OpenGLCompute for Halide 16

* clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_notes For changes that may warrant a note in README for official releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants