Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save_tiff() PlanarConfig assignment for monochrome inputs #7568

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix save_tiff() PlanarConfig assignment for monochrome inputs #7568

merged 1 commit into from
May 15, 2023

Conversation

psmskelton
Copy link
Contributor

Fixes #7567.

@abadams abadams added the buildbot_test_everything Buildbots should run all available tests on this PR (unless build_test_nothing is set). label May 14, 2023
@steven-johnson steven-johnson self-requested a review May 15, 2023 16:38
steven-johnson
steven-johnson approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green buildbots

@steven-johnson steven-johnson merged commit f121abf into halide:main May 15, 2023
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@psmskelton @ardier
Fix save_tiff() PlanarConfig assignment for monochrome inputs (halide…
0b1ac8a 
…#7568)

Fixes halide#7567.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees
No one assigned
Labels
buildbot_test_everything Buildbots should run all available tests on this PR (unless build_test_nothing is set).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Halide::Tools::save_image() incorrect tag for PLANARCONFIG on 16-bit monochrome TIFF files.
4 participants
@psmskelton @steven-johnson @abadams @halidebuildbots