Fix bitrot in PowerPC testing #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
reviewed
Dec 7, 2022
| check("vsubuws", 16 * w, absd(i32_1, i32_2)); | ||
| // TODO: not getting generated in recent LLVM builds. | ||
| // https://github.com/halide/Halide/issues/7208 | ||
| // check("vsububs", 16 * w, absd(i8_1, i8_2)); |
There was a problem hiding this comment.
It looks like the cause was me accidentally putting these ones in the powerpc section instead of the x86 section! I don't think they're even correct, because the or-two-saturating-subtracts trick only works for unsigned.
There was a problem hiding this comment.
I'll take the liberty of pushing a fix to this branch, moving these tests to the right place.
There was a problem hiding this comment.
Wait, x86 doesn't have any instructions of those names, does it?
There was a problem hiding this comment.
It's vpsubusb on x86, which looked close enough to fool me.
zvookin
approved these changes
Dec 7, 2022
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Fix bitrot in PowerPC testing (See halide#7208) - DataLayout was wrong (and has been for a long time) - simd_op_check_powerpc had errors. Some were easy to fix; the rest I commented out with a TODO since this backend doesn't appear to be in active use. (Want to fix this in preparation for fixing halide#7207) * Move x86 absd tests to the right place Co-authored-by: Andrew Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See #7208)
(Want to fix this in preparation for fixing #7207)
(Note to reviewers: this isn't being run on the buildbots, so there shouldn't be any failures -- if you want to test right now, run locally and set HL_TARGET appropriately)