Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable simd_op_check test for wasm i8x16.popcnt #6562

Merged
merged 1 commit into from
Jan 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Enable simd_op_check test for wasm i8x16.popcnt
LLVM does in fact generate this correctly, but only for 8x16 sized vectors
steven-johnson committed Jan 14, 2022

Verified

This commit was signed with the committer’s verified signature.
jalaziz Jameel Al-Aziz
commit 2e583921e37d93add3c34a76bce35e696e4e6a24
9 changes: 2 additions & 7 deletions test/correctness/simd_op_check.cpp
Original file line number Diff line number Diff line change
@@ -2023,13 +2023,8 @@ class SimdOpCheck : public SimdOpCheckTest {
check("v128.bitselect", 2 * w, select(bool_1, f64_1, f64_2));

// Lane-wise Population Count
// TODO(https://github.com/halide/Halide/issues/5130): NOT BEING GENERATED AT TRUNK
// check("i8x16.popcnt", 8 * w, popcount(i8_1));
// check("i8x16.popcnt", 8 * w, popcount(u8_1));
// check("i8x16.popcnt", 8 * w, popcount(i16_1));
// check("i8x16.popcnt", 8 * w, popcount(u16_1));
// check("i8x16.popcnt", 8 * w, popcount(i32_1));
// check("i8x16.popcnt", 8 * w, popcount(u32_1));
check("i8x16.popcnt", 8 * w, popcount(i8_1));
check("i8x16.popcnt", 8 * w, popcount(u8_1));

// Any lane true -- for VectorReduce::Or on 8-bit data
// All lanes true -- for VectorReduce::And on 8-bit data