Skip to content

Commit

Permalink
Enable simd_op_check test for wasm i8x16.popcnt (#6562)
Browse files Browse the repository at this point in the history
LLVM does in fact generate this correctly, but only for 8x16 sized vectors
  • Loading branch information
steven-johnson authored Jan 16, 2022
1 parent e581669 commit 1aa68fb
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions test/correctness/simd_op_check.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2023,13 +2023,8 @@ class SimdOpCheck : public SimdOpCheckTest {
check("v128.bitselect", 2 * w, select(bool_1, f64_1, f64_2));

// Lane-wise Population Count
// TODO(https://github.com/halide/Halide/issues/5130): NOT BEING GENERATED AT TRUNK
// check("i8x16.popcnt", 8 * w, popcount(i8_1));
// check("i8x16.popcnt", 8 * w, popcount(u8_1));
// check("i8x16.popcnt", 8 * w, popcount(i16_1));
// check("i8x16.popcnt", 8 * w, popcount(u16_1));
// check("i8x16.popcnt", 8 * w, popcount(i32_1));
// check("i8x16.popcnt", 8 * w, popcount(u32_1));
check("i8x16.popcnt", 8 * w, popcount(i8_1));
check("i8x16.popcnt", 8 * w, popcount(u8_1));

// Any lane true -- for VectorReduce::Or on 8-bit data
// All lanes true -- for VectorReduce::And on 8-bit data
Expand Down

0 comments on commit 1aa68fb

Please sign in to comment.