Include Sass files in npm package and allow $spinnerSize Sass variable to be reassigned

[zalog]

There are 2 commits:

• solve this in a way, by isolating transition to padding, and not transitioning background-color and color.

• adding !default to sass variable which allows reassigning.

Hope it helps.

[zalog]

What happened here? Do you need some help?

[theodorejb]

It looks like the base branch was set to 2.x, so when I removed this branch GitHub closed your pull request.

[zalog]

Oh, now I see. This branch got some mess :)
I'll come back soon with a clean rebase

[theodorejb]

I fixed it for you. :)

I'm trying to understand what issue this PR fixes, though. You can test Ladda with Bootstrap 4 here, and it seems to work fine: https://theodorejb.github.io/Ladda/test/bootstrap4.html.

[zalog]

Sorry, I can't replicate that collision anymore...
It's been a long time since january, I'm getting old :(

We can keep the other commit.

[theodorejb]

For overriding the default spinner size, wouldn't it be better to use the built-in data-size attribute, or else create a custom CSS class for your buttons? The Sass files are excluded from the Ladda 2.0 npm package, anyway.

[zalog]

Oh, I see.
But imho I don't think excluding sass files are a good ideea :(
I think there are a lot of devs that use sass files and variables.

I recently made this (scroll down to #via-npm) and I think letting people customise that from pre-processors is better. Like bootstrap :)

Of course, we can close this pr if there will be no sass config.

[theodorejb]

I reverted the unnecessary Bootstrap 4 commit, and added a commit to re-include the Sass files in the npm package. Thanks for the contribution!

[zalog]

Great! Thanks for reconsider :)