Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for selects/radiobuttons/checkboxes that are required #43

Merged
merged 3 commits into from
Jan 16, 2015

Conversation

MaZZly
Copy link
Contributor

@MaZZly MaZZly commented Sep 18, 2014

Otherwise button will start spinning even though form is not posted (due to not being filled correctly)

Otherwise button will start spinning even though form is not posted (due to not being filled correctly)
@JvanderHeide
Copy link

+1

@MaZZly MaZZly changed the title Check for selects that are required Check for selects/radiobuttons/checkboxes that are required Oct 24, 2014
@MaZZly
Copy link
Contributor Author

MaZZly commented Oct 24, 2014

I noticed also that checkboxes and radiobuttons that are required are not checked for a value.
JSFiddle of wrong behaviour can be seen here: http://jsfiddle.net/ezsnw11d/

Easy to fix by checking if the input has type

@hakimel hakimel merged commit 0fdf43e into hakimel:master Jan 16, 2015
@hakimel
Copy link
Owner

hakimel commented Jan 16, 2015

Great update – thanks! Releasing a new version that includes this now (0.9.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants