Adding support for spin.js 2.0.1 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimel
added a commit
that referenced
this pull request
Jun 21, 2014
|
This has been merged and is available in the 0.9.4 release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building an Angular Application, I've been using Ladda a long time ago and this time I'm using the spin.js in a directive (https://github.com/urish/angular-spinner) but this module uses Spin.js#2.0.1 and when I check my Ladda buttons they didn't work properly so I noticed that Ladda uses 1.3.x and that was the bug. So I decided to upgrade spin.js in Ladda :)
Regards,
Kevin