Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart Sass complains about usage of / for division in ladda.scss #109

Closed
selangley-wa opened this issue Dec 2, 2021 · 2 comments
Closed

Comments

@selangley-wa
Copy link

I see messages like the below when using ladda in an Angular 12 application with Dart Sass:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spinnerSize, -2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
116 │         right: $spinnerSize/-2 + 10;
    │                ^^^^^^^^^^^^^^^
    ╵
    node_modules\ladda\css\ladda.scss 

Could we follow their recommendation and use math.div() instead?

@theodorejb
Copy link
Collaborator

@selangley-wa Thank you for reporting the issue. This is now resolved in v2.0.3.

@Donatello-za
Copy link

Donatello-za commented Jan 12, 2022

This update broke our build process (using node-sass version 7.0.1):

Module build failed: 
        right: math.div($spinnerSize, -2) + 10;
                  ^
      Invalid CSS after "...    right: math": expected expression (e.g. 1px, bold), was ".div($spinnerSize, "
      in /home/<redacted>/node_modules/ladda/css/ladda.scss (line 118, column 20)

I reverted back to 2.0.2 for now in order to get around the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Donatello-za @theodorejb @selangley-wa and others