-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with implicit imports from sub-packages #127
Comments
hakancelikdev
added
bug
Something isn't working
changelog
Changes should be written to the changelog file.
needs test
labels
Sep 29, 2020
hakancelikdev
added a commit
that referenced
this issue
Oct 7, 2020
hakancelikdev
added a commit
that referenced
this issue
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With:
unimport will remove the import, thus breaking the code. Instead, it should probably recognize that the
os
package is still used and adjust the import accordingly.It might be somewhat obvious in this case - in my case, I imported
importlib.abc
accidentally but used e.g.importlib.import_module
. When reviewing the diff for issues, I confirmed thatimportlib.abc
is indeed unused, but didn't recognize the implicit now missing import until it was too late and CI failed. 😅The text was updated successfully, but these errors were encountered: