Add buffer argument to hasher constructors #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the optional parameter
data, which accepts a bytes-like object implementing the buffer protocol, as the first argument. This change aligns the API of Python’s standardhashliblibrary.Backward Compatibility: In previous versions, the first optional argument was
seed, an integer. This update introduces a backward-incompatibility, as the new argument takes precedence. For example, code likemmh3.mmh3_x64_128(1234)will now raise an errorTypeError: a bytes-like object is required, not 'int'.Version Update: Due to this breaking change, I will bump the version to 5.0.0 in accordance with semantic versioning.