chore: Switch from gometalinter to golangci-lint#547
Merged
hairyhenderson merged 2 commits intohairyhenderson:masterfrom May 3, 2019
Merged
chore: Switch from gometalinter to golangci-lint#547hairyhenderson merged 2 commits intohairyhenderson:masterfrom
hairyhenderson merged 2 commits intohairyhenderson:masterfrom
Conversation
Contributor
Author
|
I do not know how circle ci works. But it seems that the provided golangci-lint version is not the newest. |
Contributor
Author
|
Please see: hairyhenderson/dockerfiles#55 for a fix for the lint error. |
Owner
|
Thanks @nexeck! I'm going to add some commits to this PR - |
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
approved these changes
May 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Issue: #546