Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing-key flag to manage behavior in case of non-existing key #1949

Merged

Conversation

xxxcoltxxx
Copy link
Contributor

This pull request allow to control behavior in case of non-existent keys. It described in the issue #1948

gomplate_test.go Outdated Show resolved Hide resolved
@hairyhenderson
Copy link
Owner

Thanks for working on this @xxxcoltxxx!

In addition to the comments I've made so far, I'd like to see an integration test added to cover both file-based config and flag-based config.

Also, the documentation needs updating as well.

render.go Outdated Show resolved Hide resolved
@xxxcoltxxx
Copy link
Contributor Author

Thanks for working on this @xxxcoltxxx!

In addition to the comments I've made so far, I'd like to see an integration test added to cover both file-based config and flag-based config.

Also, the documentation needs updating as well.

Added

@xxxcoltxxx
Copy link
Contributor Author

xxxcoltxxx commented Dec 19, 2023

Thanks for working on this @xxxcoltxxx!

In addition to the comments I've made so far, I'd like to see an integration test added to cover both file-based config and flag-based config.

Also, the documentation needs updating as well.

Docs/integration tests added

@hairyhenderson
Copy link
Owner

Thanks @xxxcoltxxx - overall this looks good, just a few doc adjustments needed, as noted. The unit tests and linter need to be fixed, and then this can be merged.

Thanks again for your work on this!

@xxxcoltxxx
Copy link
Contributor Author

@hairyhenderson Fixed tests/linter/docs

Thanks for this repository. It helps a lot

Copy link
Owner

@hairyhenderson hairyhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on this, @xxxcoltxxx!

@hairyhenderson hairyhenderson merged commit f837061 into hairyhenderson:main Jan 17, 2024
13 checks passed
@philippeboyd
Copy link

Hi @hairyhenderson,

Would this feature be available in v3 (maybe 3.12) or do we need to wait v4 or build main ourselves?

Thanks

@hairyhenderson
Copy link
Owner

@philippeboyd there won't be a 3.12, you'll need to wait for 4.0 or build yourself. I've tagged a pre-release version (v4.0.0-pre-2) and will be building some binaries for it soon!

@aviadhaham
Copy link

@hairyhenderson first of all, thank you for this great project.
I just wanted to ask when you think v4.0.0 will be released? I just found I need that feature 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants