-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing-key flag to manage behavior in case of non-existing key #1949
Add missing-key flag to manage behavior in case of non-existing key #1949
Conversation
103e764
to
362700f
Compare
Thanks for working on this @xxxcoltxxx! In addition to the comments I've made so far, I'd like to see an integration test added to cover both file-based config and flag-based config. Also, the documentation needs updating as well. |
Added |
Docs/integration tests added |
Thanks @xxxcoltxxx - overall this looks good, just a few doc adjustments needed, as noted. The unit tests and linter need to be fixed, and then this can be merged. Thanks again for your work on this! |
@hairyhenderson Fixed tests/linter/docs Thanks for this repository. It helps a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for working on this, @xxxcoltxxx!
e9af3cb
to
f914fc9
Compare
…e missing-key flag
Co-authored-by: Dave Henderson <[email protected]>
f914fc9
to
d29a1b7
Compare
Hi @hairyhenderson, Would this feature be available in v3 (maybe Thanks |
@philippeboyd there won't be a 3.12, you'll need to wait for 4.0 or build yourself. I've tagged a pre-release version (v4.0.0-pre-2) and will be building some binaries for it soon! |
@hairyhenderson first of all, thank you for this great project. |
This pull request allow to control behavior in case of non-existent keys. It described in the issue #1948