Fix file descriptor leak #1643
Merged
Fix file descriptor leak #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
fix-open-file-leak
branch
2 times, most recently
from
7d36477
to
52bcbf8
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
fix-open-file-leak
branch
from
52bcbf8
to
5d7bb0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd been ignoring the locally-failing
TestInputDir_RespectsUlimittest because it passed on Linux. But after some deeper inspection it looks like it's an actual failure, and maybe the ulimit setting is not actually working on Linux during the test.The leak is fairly obvious - it's a defer called in a loop that should be called in a separate function.