[vds/docs] Fix erroneous gvcf_batch_size description #14784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Is "pipeline" the right term to use here? I feel like most users would think the entire combiner process was a pipeline. What about "stage"?
I think it's still not clear that branch_factor GVCFs are merged into each VDS. Maybe we could reword the branch_factor description to something like "The number of inputs (VDSs or GVCFs) combined into each intermediate Variant Dataset"?
Also clarify branch_factor description
chrisvittal
force-pushed
the
vds/docs-fix-1
branch
from
566f83e to
68e96cd
Compare
ehigham
approved these changes
Jan 21, 2025
|
@patrick-schultz can you take another look? |
patrick-schultz
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14781
Security Assessment
Impact Description
Docs only