don't hardcode paths to test resources #14775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 7, 2025
patrick-schultz
force-pushed
the
ps/scala-test-resource-paths
branch
from
7f1e1d2 to
1e5dc96
Compare
cjllanwarne
approved these changes
Jan 7, 2025
cjllanwarne
pushed a commit
to cjllanwarne/hail
that referenced
this pull request
Jan 17, 2025
## Change Description hail-is#14775 missed some places in the scala tests where the test resources directory is hardcoded. This fixes the remaining cases. ## Security Assessment Delete all except the correct answer: - This change has no security impact ### Impact Description Tests-only change (Reviewers: please confirm the security impact before approving)
grohli
pushed a commit
to grohli/hail
that referenced
this pull request
Jan 27, 2025
## Change Description Factor out the location of the test resources directory in the scala tests, so we only need to change one place when we rearrange the directory structure. ## Security Assessment - This change has no security impact ### Impact Description Tests only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Factor out the location of the test resources directory in the scala tests, so we only need to change one place when we rearrange the directory structure.
Security Assessment
Impact Description
Tests only