Repository navigation
Conversation
Signed-off-by: haic0 <haic0@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_file_dependenciesto every AMD ready, merge, and nightly job.amd_ci_sharedsafety key for Buildkite, ROCm image, dependency, and shared runtime changes.mainnightly runs while filtering PR-label and post-merge suites.Stacking and GitHub limitation
This helper PR is stacked on vllm-project#7311 and depends on it. Its base is the exact parent branch,
haic0:ci/rocm-amd-uploader-refactor-replacement, so the diff contains only AMD source-filtering changes.GitHub rejected an upstream stacked PR because a PR in
vllm-project/vllm-omnicannot use the fork-owned parent branch as its base (GraphQL: The baseRefName is invalid). Therefore this helper PR lives inhaic0/vllm-omni. After vllm-project#7311 merges, rebase this branch onto upstreammainand open the follow-up PR invllm-project/vllm-omniagainstmain.Dependency policy
Every AMD leaf job combines
amd_ci_sharedwith a focused registry key covering the test target, model family, and relevant runtime paths.amd_ci_sharedretains the full selected AMD suite for.buildkite/**, ROCm Docker/image inputs, requirements and packaging files, shared test fixtures, and broad platform/config/runtime files where impact cannot be safely inferred.Missing declarations already keep jobs. AMD now also treats empty, malformed, unknown, or unavailable dependency mappings as fail-open, logging the reason and retaining the job. Scheduled
mainnightly builds disable source filtering and keep all nightly jobs.Why this is not a duplicate
Before implementation, I inspected vllm-project#7311 and its comments, searched open PRs for
source_file_dependencies AMD ROCmandAMD source filtering, and searched recent merged PRs in the same area. No open or merged PR adds AMD per-job source filtering. vllm-project#6597 introduced the shared filtering machinery for CUDA/NPU; vllm-project#7311 adds the AMD native uploader lifecycle that this follow-up builds on.Validation
.venv/bin/python -m pytest --confcutdir=tests/buildkite tests/buildkite/test_upload_pipeline.py tests/buildkite/test_amd_suite_selection.py tests/buildkite/test_amd_pipeline.py tests/buildkite/test_skip_ci.py -q— 133 passed.PATH="$PWD/.venv/bin:$HOME/.cargo/bin:$PATH" uvx pre-commit run --files <changed files>— all applicable hooks passed, including Ruff, mypy, YAML, and Buildkite validation.minijinja-cliand parsed as valid YAML; the Qwen3-TTS change retained the mapped TTS job (plus the conservative broad CPU lane), omitted Wan22, and leaked no uploader-only dependency fields.git diff --checkpassed.AI assistance
AI assistance was used for repository investigation, dependency-map drafting, implementation, tests, and validation. The human submitter must review and understand every changed line before merge.
Follow-up
After vllm-project#7311 merges, rebase this branch onto upstream
main, open an upstream PR againstmain, and rerun the focused Buildkite validation against the merged uploader lifecycle.