Add cert validity dates and serial number to SslInfo#654
Merged
Conversation
Populate NotBefore, NotAfter and SHA-1 thumbprint for both remote and local certs, on the SslStream and BouncyCastle paths. Also fix LocalCertificatePem being sourced from the remote cert.
Issuer plus serial uniquely identifies a cert per RFC 5280, and both providers expose it as a plain field, so no hashing on every TLS handshake.
haga-rak
changed the title
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate
NotBefore,NotAfterandSerialNumberfor both the remote and local certificates onSslInfo, covering the .NETSslStreampath and the BouncyCastle path. Also fixesLocalCertificatePembeing sourced from the remote certificate.