Fix use-after-free in header info classes causing buffer corruption#583
Merged
Conversation
RequestHeaderInfo, HeaderFieldInfo, and ResponseHeaderInfo stored ReadOnlyMemory<char> slices pointing directly into MemoryPool<char> buffers managed by ExchangeScope. When the scope was disposed and the buffer recycled, lazily-evaluated properties like ExchangeInfo.FullUrl would read corrupted data from the reused buffer. Materialize pooled Memory<char> slices into string-backed memory at construction time, and eagerly evaluate header LINQ projections with ToList() to prevent deferred enumeration after buffer recycling.
This was referenced Mar 30, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestHeaderInfo,HeaderFieldInfo, andResponseHeaderInfostoredReadOnlyMemory<char>slices pointing directly intoMemoryPool<char>buffers managed byExchangeScope. When the scope was disposed and the buffer was recycled for subsequent HTTP traffic, lazily-evaluated properties likeExchangeInfo.FullUrlwould read corrupted data from the reused buffer.Memory<char>slices into string-backed memory via.ToString().AsMemory()at construction time inRequestHeaderInfoandHeaderFieldInfo, so the data is owned and not subject to pool recycling..ToList()inRequestHeaderInfoandResponseHeaderInfoto prevent deferred enumeration after the backing buffer has been returned to the pool.