Add the cplocn2atm namelist option to turn on/off ocean feedback to FV3#7
Merged
Merged
Conversation
…., SST) to the atmosphere model component. It is useful to control the one-way or two-way atmosphere-ocean coupling.
BinLiu-NOAA
requested review from
BijuThomas-NOAA,
ChunxiZhang-NOAA,
JohnSteffen-NOAA,
MariaAristizabal-NOAA,
danrosen25 and
hyunsookkim-NOAA
Author
|
Hi @danrosen25, @ChunxiZhang-NOAA , and others, wondering if you could help to review this set of changes when you get a chance. If they look good to you, after merging back to support/HAFS branch, we will also try to create a PR to merge it back the authoritative develop branch under NOAA-EMC/fv3atm. Thanks! |
|
The code changes look good but let me run tests after I run the new ww3 coupling tests. |
Author
|
Merging this branch back to support/HAFS. Will create a PR to merge this capability back to NOAA-EMC/FV3atm develop branch as well. |
BijuThomas-NOAA
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Update diagnose_cplFields routine to use FieldBundleWrite. Needs esmf v8.6.0 * Fixed bug in aux2d dimensions for GFS meta file. * Pass return code from diagnose_cplFields back to caller * Skip 'cpl_scalars' field when dumping export state * fix fhzero for GEFS * fix cpl_scalars (#6) * fix issues w/ cplscalars * error out of all 3 spatial indices are not present * add check for scalar_id = 0 * modify for timeslices and times (#7)
BinLiu-NOAA
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Update diagnose_cplFields routine to use FieldBundleWrite. Needs esmf v8.6.0 * Fixed bug in aux2d dimensions for GFS meta file. * Pass return code from diagnose_cplFields back to caller * Skip 'cpl_scalars' field when dumping export state * fix fhzero for GEFS * fix cpl_scalars (#6) * fix issues w/ cplscalars * error out of all 3 spatial indices are not present * add check for scalar_id = 0 * modify for timeslices and times (#7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when running coupled configurations/applications (e.g., HAFS or S2S). There is no available option to control one-way coupling to turn off the ocean model component feedback (e.g., SST) to FV3ATM.
Similar to the cplwav2atm namelist option, add a cplocn2atm namelist option to turn on/off the ocean model component feedback (e.g., SST) to the atmosphere model component. This is useful to control the one-way or two-way atmosphere-ocean coupling, as well as to configure different combinations for the atmosphere-ocean-wave coupling in HAFS and/or other applications.