Latest updates to address NoahMP LSM and moving nesting related issues#20
Merged
Merged
Conversation
Mainly based on checking/testing/discussion and working sessions among @barlage, @wramstrom, @RongqianYang-NOAA, @ChuankaiWang-NOAA, @BijuThomas-NOAA, @BinLiu-NOAA. - Improve the fill_nest_halos_from_parent_masked interface to handle both default and missing/fill values; Update and properly set default and missing values for related varialbes. (@wramstrom, @BinLiu-NOAA) - Update and properly set default and missing values for some NoahMP LSM varialbes. (@barlage, @wramstrom, @BinLiu-NOAA) - Add handling additional variables for nest moving: srflag, snodl, weasdl, snodi, weasdi, and zorli. (@ChuankaiWang-NOAA, @BinLiu-NOAA)
BinLiu-NOAA
requested review from
ChuankaiWang-NOAA,
RongqianYang-NOAA,
barlage and
wramstrom
…d LSM. - Improve the fill value specificiation. - Improve the sanity check for tisfc. - Replace the hardcoded kice with GFS_Control%kice. Changes made during the discussion and working session among @barlage, @wramstrom, @ChuankaiWang-NOAA, @BijuThomas-NOAA, @ZhanZhang-NOAA, @BinLiu-NOAA.
Author
|
@ChuankaiWang-NOAA I have committed and pushed our latest source code changes from today's discussion/working session. Please use this latest version to repeat the RELEASE and DEBUG build runs you conducted. Thanks! |
|
OK. I will test with the latest changes. |
Author
|
Merging these changes into feature/hafsv2p2_final branch for HAFSv2.2 package freeze. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly based on checking/testing/discussion and working sessions among @barlage, @wramstrom, @RongqianYang-NOAA, @ChuankaiWang-NOAA, @BijuThomas-NOAA, @BinLiu-NOAA.