Skip to content

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19#2

Merged
climbfuji merged 43 commits into
hafs-community:support/HAFSfrom
climbfuji:update_hafs_from_dtc_hwrf_physics_20200619
Jun 26, 2020
Merged

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19#2
climbfuji merged 43 commits into
hafs-community:support/HAFSfrom
climbfuji:update_hafs_from_dtc_hwrf_physics_20200619

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Jun 19, 2020 •
edited
Loading

This PR adds the HWRF physics to ccpp-physics. All development was made in the NCAR fork, branch dtc/hwrf-physics. Commit log from this branch:

ccpp-physics
------------

04/06/2020 MONINEDMF https://github.com/NCAR/ccpp-physics/pull/395 -> https://github.com/NCAR/ccpp-physics/pull/428
    git cherry-pick 942889ab0acace519254712cb4e14b6aaf3e0415
    git cherry-pick 500d53a21027f362a9c12c10767f0b4f8cf3361c
    git cherry-pick b0f04b210bd588673182023ea36b56ee94642c3e
    git cherry-pick e895c62cf49b908927678d72c1ad21ad828e3587

04/08/2020 RRTMG https://github.com/NCAR/ccpp-physics/pull/412 -> https://github.com/NCAR/ccpp-physics/pull/430
    git cherry-pick 9e9222a470dd8a644ba4c3d010766c62dc71de59
    git cherry-pick 4d9e68fc27bb3974f1a6c5733bf1b8127165581d
    git cherry-pick 6f9fec9d183531c81475b3496504dc3225011472
    git cherry-pick 57873f2045e1cd2d09c71481c0593f3d7eee24ef
    git cherry-pick 7e492ca69cab20d2457af82c5d535d8b64e2ab1e
    git cherry-pick 298d1aed7b2f29ccf624a71be7d9f804eaf9e8ab
    git cherry-pick 5404462a72fe10477595c25baab0ae28fe667f0f

04/13/2020 SAS https://github.com/NCAR/ccpp-physics/pull/423 -> https://github.com/NCAR/ccpp-physics/pull/433
    (entire PR)
    --> this PR and other SAS PRs below need to be merged separately
    into the authoritative repositories, because the answer of some
    of the IPD and CCPP prod tests change (kept PRs open)

04/16/2020 FA MP updates https://github.com/NCAR/ccpp-physics/pull/405 -> https://github.com/NCAR/ccpp-physics/pull/435
    (entire PR)

05/04/2020 FA/HWRF RRTMG/HWRF SAS bugfixes https://github.com/NCAR/ccpp-physics/pull/447
    (entire PR)

05/20/2020 fix FA table initialization https://github.com/NCAR/ccpp-physics/pull/450 -> https://github.com/NCAR/ccpp-physics/pull/453
    (entire PR)

05/20/2020 update from HAFS community https://github.com/NCAR/ccpp-physics/pull/453
    (entire PR)

06/18/2020 update from HAFS community https://github.com/NCAR/ccpp-physics/pull/463
    (entire PR)

Associated PRs:
hafs-community/ufs-weather-model#5
hafs-community/ufsatm#5
#2

For regression testing information, see below hafs-community/ufs-weather-model#5.

climbfuji and others added 30 commits April 3, 2020 09:44
@climbfuji
Update CODEOWNERS for HWRF physics development
1df7376
@grantfirl @climbfuji
add hurricane-specific code to moninedmf.f
10867d1
@grantfirl @climbfuji
clean up logic to better align with HAFS version from Bin Liu, Chunxi…
cce995d 
… Zhang, Weiguo Wang, and Qingfu Liu
@grantfirl @climbfuji
send constants through the argument list
e839247
@grantfirl @climbfuji
send constants through physcons module; sending constants through the…
78c03e0 
… argument list (specifically grav and cp) causes regression test failures in PROD mode
@climbfuji
physics/moninedmf.{f,meta}: apply missing updates that were hidden in…
b492f72 
… a update-from-dtc-develop commit
@climbfuji
Merge pull request NCAR#428 from climbfuji/dtc-hwrf-physics-add-monin…
0346c38 
…edmf

dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL)
@mzhangw @climbfuji
enable icloud=3 capability
a8a2ab8
@mzhangw @climbfuji
add exponential cloud overlapping for LW component
9309fc6
@mzhangw @climbfuji
finalize HWRF RRTMG LW capability
5597b2c
@mzhangw @climbfuji
HWRF RRTMG cloud-rad interaction
bb68108
@mzhangw @climbfuji
add progcld6 for GSD suite
c47c2cb
@mzhangw @climbfuji
remove the connection of iovrlw/iovrsw with physparam
ac32ce0
@mzhangw @climbfuji
add new radlw/radsw main with modern fortran
5404462
@climbfuji
Clean up HWRF RRTMG additions
28d1bc2
@climbfuji
Cleanup comments in newly added/modified radiation code
2933be7
@climbfuji
Merge pull request NCAR#430 from climbfuji/dtc_hwrf-physics_add_rrtmg
6c27ff2 
dtc/hwrf-physics: HWRF RRTMG (based on NCAR#412)
@climbfuji
Merge branch 'man_hafs_sas_for_master' of https://github.com/climbfuj…
ffc2755 
…i/ccpp-physics into HEAD
@climbfuji
Merge remote-tracking branch 'ncar/dtc/hwrf-physics' into merge_hwrf-…
02bede0 
…sasas_into_dtc_hwrf-physics
@climbfuji
Merge pull request NCAR#433 from climbfuji/merge_hwrf-sasas_into_dtc_…
dd891d8 
…hwrf-physics

dtc/hwrf-physics: merge HWRF saSAS with GFS version, update to a more recent version of ccpp-physics from master
@mzhangw @climbfuji
Merge mzhangw:HAFS_fer_hires into NCAR:dtc/hwrf-physics
6a8c80e 
Squashed commit of the following:

commit 406f740
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Apr 13 20:24:59 2020 -0600

    FA uses progcld5

commit 682fab9
Merge: 25b3f66 d979604
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Mar 16 10:42:12 2020 -0600

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 25b3f66
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Mar 16 10:37:42 2020 -0600

    modify stateout update of FA scheme

commit 05c5331
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Tue Feb 11 16:45:48 2020 -0700

    sci doc updates

commit 982a11d
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Fri Feb 7 16:47:00 2020 -0700

    FA sci doc updates

commit 27c1fcb
Merge: 8d87e55 73f9f09
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Fri Feb 7 14:26:54 2020 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 8d87e55
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Fri Feb 7 14:24:47 2020 -0700

    FA scientific documentation

commit 67ad5a5
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Dec 11 13:13:48 2019 -0700

    consolidate with Chunxis version

commit 76b5475
Merge: 7c6a472 02812f6
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Dec 11 11:49:22 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 7c6a472
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Dec 5 16:28:50 2019 -0700

    output mass weighted RF in GFS_suite_stateout_update_run, it will used in FA

commit 41086af
Merge: 92d9edf f895fc0
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Dec 5 12:08:30 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 92d9edf
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Nov 25 14:16:16 2019 -0700

    chunxi fix : f_rimef = qg in FA code

commit f9e3ee0
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Nov 25 11:39:54 2019 -0700

     From Eric: convert wet mixing ratios of cloud species to mixing ratio
    before the scheme, and convert back after scheme.

     From Chunxi, modify: 1. FA interface with GFS RRTMG using progcld2;
    2.air pressure improvement; 3. add f_qrimef mixing in PBL

commit f497d40
Merge: bd4a30c 73b8c0d
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Nov 25 09:44:14 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit bd4a30c
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Fri Nov 22 14:30:16 2019 -0700

    monir format fix

commit 4c2abd1
Merge: db7fc8d a7c38a6
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 21 19:29:50 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit db7fc8d
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 21 19:29:04 2019 -0700

    minor change

commit ab52b26
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 21 18:48:53 2019 -0700

    delete update_moist module

commit db9e3a7
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Nov 18 14:40:10 2019 -0700

    cleanup FA codes

commit 482a43b
Merge: 380229c 74851c1
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Nov 18 14:31:07 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 380229c
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 14 13:46:13 2019 -0700

     1. do some code cleanup
     2. correct tracer diffusions definition before/after PBL in
    GFS_PBL_generic

commit a312444
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Nov 11 10:52:21 2019 -0700

     Chunxi's email 11/07/2019: the srflag is based on sr. so we need to
     make sure 'cal_pre' is always set to false in namelist file.

commit f2c9271
Merge: 6777489 333980d
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 7 11:03:56 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 6777489
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 7 10:56:33 2019 -0700

    add Chunxi GFS_MP_generic change related to FA scheme

commit 327b07f
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Oct 23 19:56:11 2019 -0600

    minor fix

commit bfedaab
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Oct 23 09:44:46 2019 -0600

    add meta files for FA scheme and HAFS_update_moist

commit a5b5fa9
Merge: 1ff46c7 cfafb29
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Fri Oct 18 09:56:40 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 1ff46c7
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Oct 8 20:42:58 2019 -0600

    add update_moist() module to F-A suite

commit 258fceb
Merge: 53fba5b ecb641e
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Oct 7 15:36:47 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 53fba5b
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Oct 7 14:55:21 2019 -0600

    1. recalculate some FAmp tables which depend on physics time step in F-A scheme
    2. change ncw value to HWRF application

commit 1656aac
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Sep 30 12:02:24 2019 -0600

    revert MP_generic to original version to obtain B4B for control/csawmg/satmedmf

commit dfccc5b
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Sun Sep 29 11:06:55 2019 -0600

    fix bugs in GFS_PBL_generic

commit fc744d3
Merge: 1a024b7 dc74b57
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Sep 23 14:17:29 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 1a024b7
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Fri Sep 20 22:01:07 2019 -0600

    fix ccpp_control crashed problem

commit 957ff82
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Sep 19 10:14:59 2019 -0600

    turn on/off spec_adv option is working in CCPP F-A scheme.

commit 370d49f
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Sep 17 16:55:24 2019 -0600

    use progcld5 for F-A in GFS_rrtmg_pre

commit bbbf155
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Sep 12 09:19:17 2019 -0600

    F-A scheme modification related to meta data file update

commit 2b8d9e4
Merge: 08662ae 9fc5ac1
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Sep 11 16:15:30 2019 -0600

    Merge branch 'HAFS_fer_hires' of https://github.com/mzhangw/ccpp-physics into HAFS_fer_hires

commit 08662ae
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Sep 11 16:14:47 2019 -0600

    add vars to meta table

commit 9fc5ac1
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Wed Sep 11 16:12:00 2019 -0600

    initialize Doxygen documentation in F-A scheme

commit d749a68
Merge: dff5b0f 20dd8d2
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Sep 10 15:19:15 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit dff5b0f
Merge: bed9c0e 727417c
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Sep 4 14:30:28 2019 -0600

    Merge branch 'chunxi_physics' of https://github.com/ChunxiZhang-NOAA/ccpp-physics into HAFS_fer_hires

commit bed9c0e
Merge: 1f8a26a 44137a3
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Sep 4 14:26:51 2019 -0600

    Merge branch 'HAFS_fer_hires' of https://github.com/mzhangw/ccpp-physics into HAFS_fer_hires

commit 1f8a26a
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Sep 4 14:24:27 2019 -0600

    bug fixed in augument list of FER_HIRES

commit 44137a3
Merge: 1808226 6abba22
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Sep 3 10:33:04 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 1808226
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Sat Aug 31 17:51:49 2019 -0600

    tracer treatment fix

commit 727417c
Author: Chunxi.Zhang-NOAA <Chunxi.Zhang@noaa.gov>
Date:   Fri Aug 30 22:13:06 2019 +0000

    GFS_MP_generic.F90: recalculate srflag
    GFS_PBL_generic.F90: define tracers for vertical diffusion
    GFS_rrtmg_pre.F90: change ncnd
    module_mp_fer_hires_pre.F90: revised the definition to tracers
    mp_fer_hires.F90: revised the definition to tracers

commit ec729e8
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Aug 29 21:43:36 2019 -0600

    make consistent standard name as Chunxis implementation

commit 3a26975
Merge: 1426c6e c7faeb7
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Aug 29 21:02:59 2019 -0600

    Merge branch 'chunxi_physics' of https://github.com/ChunxiZhang-NOAA/ccpp-physics into HAFS_fer_hires

commit 1426c6e
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Aug 29 20:32:12 2019 -0600

    fix omp message and pass F-A scheme

commit c7faeb7
Author: Chunxi.Zhang-NOAA <Chunxi.Zhang@noaa.gov>
Date:   Thu Aug 29 16:20:51 2019 +0000

    mp_fer_hires.F90: changed the definitions for f_ice, f_rain and f_rimef.
                      Deleted QS since it will not be used. we only need QI.
    module_mp_fer_hires_pre.F90: changes related to f_ice, f_rain and f_rimef
    module_mp_fer_hires_pre.F90: added

commit 4e0d9bd
Merge: 9aaa575 01823bc
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Aug 27 17:13:12 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit 9aaa575
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Aug 27 15:57:43 2019 -0600

    minor fix

commit 6b88864
Author: Eric Aligo <eric.aligo@noaa.gov>
Date:   Tue Aug 27 17:31:03 2019 +0000

    Fixed bug to allow both Qi and Qc to be updated from CU scheme.

commit 73f95a6
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 26 22:05:00 2019 -0600

    fortran format fix

commit d5f8a62
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 26 17:16:30 2019 -0600

    minor fix

commit fb011da
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 26 17:05:04 2019 -0600

    Aligo-use the dx of the 1st i poit to set an integer value of dx to be used for determining RHgrd

commit 80fedc4
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 26 13:41:24 2019 -0600

    further constants fix

commit 473ff9e
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 26 10:45:49 2019 -0600

    dimension fixed

commit c29c3cd
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Sun Aug 25 22:44:04 2019 -0600

    convert USE ESMF to ccpp mpi method; temporary constant treatment

commit 8b886b9
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Aug 21 11:06:19 2019 -0600

    delete HWRF F-A scheme

commit b78a1a2
Merge: dbabee7 ff2c6d8
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 19 13:42:42 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit dbabee7
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 19 13:41:36 2019 -0600

    update

commit 7c481b5
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Aug 15 08:34:33 2019 -0600

    initialize FER_HIRES scheme

commit bbac675
Merge: d06f755 fb29006
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Aug 5 10:33:29 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into HAFS_fer_hires

commit d06f755
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Aug 1 11:29:43 2019 -0600

    minor fix

commit 970ae66
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Wed Jul 31 13:41:12 2019 -0600

    change file name

commit d666a3e
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Wed Jul 31 12:25:36 2019 -0600

    pass prebuild

commit 63f07c4
Merge: d0d4035 6bb0897
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Wed Jul 31 10:10:31 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into FA-HWRF-V4_0a

commit d0d4035
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Wed Jul 31 10:09:44 2019 -0600

    initialize FER_HIRES implementation

commit e77c0a1
Author: Man Zhang <Man.Zhang@noaa.gov>
Date:   Fri Jul 19 14:55:03 2019 -0600

    add fer_hires wrapper module

commit 193435b
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Mon Jul 1 16:31:01 2019 -0600

    initialize Ferrier-Aligo MP scheme implementation from HWRF V4.0
@climbfuji
Merge pull request NCAR#435 from climbfuji/HAFS_fer_hires_for_dtc_hwr…
08bcc39 
…f-physics

dtc/hwrf-physics: HWRF Ferrier-Aligo MP scheme updates
@mzhangw
fix unitialized parameter and dimensions in FA
cb2d558
@mzhangw
fix unitialized parameters in samfdeepcnv
b084396
@mzhangw
bug fix in HWRF RRTMG
d35fad0
@climbfuji
Merge pull request NCAR#447 from mzhangw/dtc_hwrf_physics
eddf41c 
Bug fix in FA, HWRF RRTMG and HWRF SAS.
@mzhangw
add force_read_ferhires capability in FA
ef38696
@mzhangw
Merge branch 'dtc/hwrf-physics' of https://github.com/NCAR/ccpp-physics…
ce348d9 
… into dtc_hwrf_physics
@grantfirl
addition of HWRF Noah LSM and GFDL surface layer; for HWRF Noah LSM 1…
4233a04 
…) edit CMakeLists.txt to remove inoperative set_source_file_properties statement 2) edit GFS_surface_generic.F90 to handle ivegsrc=3,4,5 3) edit sfc_drv.f, sfc_drv_ruc.F90, sfc_noahmp_drv.F to check for valid ivegsrc, isot 4) add Noah working routines module_sf_noahlsm.F90 and module_sf_noahlsm_glacial_only.F90 5) add CCPP-compliant sfc_noah_wrfv4 scheme and associated interstitials; for GFDL surface layer 1) add module_sf_exchcoef.f90 for internal subroutines and 2) gfdl_sfc_layer as CCPP-compliant GFDL surface layer scheme
@climbfuji
Merge branch 'support/HAFS' of https://github.com/hafs-community/ccpp…
e072e17 
…-physics into HEAD
ChunxiZhang-NOAA
ChunxiZhang-NOAA reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ChunxiZhang-NOAA ChunxiZhang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify CIACW in module_MP_FER_HIRES.F90.
Change it from CIACW=DT0.25PI_E0.5(1.E5)**C1 to CIACW=DT0.25PI_E*0.5
This is a bug we found last year and we recently noticed that it is still in CCPP.

@mzhangw
Copy link
Copy Markdown

mzhangw commented Jun 19, 2020 via email

@ChunxiZhang-NOAA
Copy link
Copy Markdown
Collaborator

ChunxiZhang-NOAA commented Jun 19, 2020

It is in last year's HWRF. We did some tests in HWRF to tune this parameter and found
CIACW=DT0.25PI_E*1.0 is the best
This is in 2020 version of HWRF

ligiabernardet
ligiabernardet reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown

@ligiabernardet ligiabernardet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me.
Regarding the tuning change that @ChunxiZhang-NOAA suggested, one possibility is to accept this PR as is (so it reflects the code used for DTC in all tests) and then Chunxi can immediately apply the change in the hafs-community repository.

@WeiguoWang-NOAA
Copy link
Copy Markdown

WeiguoWang-NOAA commented Jun 19, 2020

This bug exists in operational HWRF. This fix will need a PR. It would be interesting to compare the before/after results.
…
On Jun 19, 2020, at 10:38 AM, ChunxiZhang-NOAA @.**> wrote: @ChunxiZhang-NOAA commented on this pull request. Please modify CIACW in module_MP_FER_HIRES.F90. Change it from CIACW=DT0.25PI_E0.5(1.E5)**C1 to CIACW=DT0.25PI_E0.5 This is a bug we found last year and we recently noticed that it is still in CCPP. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TW2W3EVY46WV4R5WOKF3RXOIBHANCNFSM4OCZ3MIA.

this can have impacts on intensity, little on tracks.

BinLiu-NOAA and others added 2 commits June 24, 2020 15:05
@BinLiu-NOAA
Cleanup trailing whitespace for some new added/modified source code r…
100a646 
…elated to hwrf_physics.
@climbfuji
Merge pull request #4 from hafs-community/feature/merge_hwrf_physics
a8265eb 
Cleanup trailing white space for some hwrf physics related source code
@BinLiu-NOAA BinLiu-NOAA mentioned this pull request Jun 25, 2020
Merged
BinLiu-NOAA
BinLiu-NOAA approved these changes Jun 26, 2020
View reviewed changes
Copy link
Copy Markdown

@BinLiu-NOAA BinLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAFS workflow and ufs-weather-model level regression tests all went through. Ready to merge this PR.

@climbfuji climbfuji merged commit c13b36d into hafs-community:support/HAFS Jun 26, 2020
BinLiu-NOAA pushed a commit that referenced this pull request Jul 3, 2020
@joeolson42
Merge pull request #2 from NOAA-GSD/gsd/develop
344c852 
updating fork
BinLiu-NOAA pushed a commit that referenced this pull request Jul 3, 2020
@joeolson42
Merge pull request #2 from NOAA-GSD/gsd/develop
008cf1a 
updating fork
BinLiu-NOAA pushed a commit that referenced this pull request Dec 12, 2020
@tanyasmirnova
Merge pull request #2 from climbfuji/gcycle_tanya_update_from_dom_2
32ffcfb 
Increase length of message and update declaration in qcmxmn to avoid writing out of bounds
BinLiu-NOAA pushed a commit that referenced this pull request Mar 31, 2021
@pjpegion
Merge pull request #2 from NCAR/master
f2a8df4 
update from NCAR's master
BinLiu-NOAA pushed a commit that referenced this pull request May 11, 2021
@llpcarson
Merge pull request #2 from mzhangw/scidocv5_sync
87528e1 
CCPPv5.0.0 scientific doc sync
BinLiu-NOAA pushed a commit that referenced this pull request Mar 6, 2022
@XiaSun-Atmos
Merge pull request #2 from climbfuji/constant_xia_update_from_main_20…
859e48e 
…210729

Update "constant" branch with latest changes in authoritative repositories
BinLiu-NOAA pushed a commit that referenced this pull request Mar 6, 2022
@hannahcbarnes
Merge pull request #2 from climbfuji/hannah_GF_RadiationUpdate_Revert…
5a7d775 
…Aerosols_dom_20210823_2

Hannah gf radiation update revert aerosols dom 20210823 part 2
BinLiu-NOAA pushed a commit that referenced this pull request Mar 6, 2022
@gthompsnWRF
Merge pull request #2 from climbfuji/new_thompson_cloud_fraction_upda…
24d850d 
…te_from_main_20211122

New Thompson cloud fraction update from main 2021/11/22
BinLiu-NOAA pushed a commit that referenced this pull request Mar 6, 2022
@RuiyuSun
Merge pull request #2 from climbfuji/cloud_cover_xr_dom
890df49 
Cloud cover xr dom
BinLiu-NOAA pushed a commit that referenced this pull request Mar 6, 2022
@JeffBeck-NOAA
Merge pull request #2 from grantfirl/feature/stoch_spp_gjf
1e02fc8 
edit module_mp_thompson.F90 to remove optional keyword for rand_pert …
@climbfuji climbfuji deleted the update_hafs_from_dtc_hwrf_physics_20200619 branch June 27, 2022 03:30
BinLiu-NOAA pushed a commit that referenced this pull request Aug 19, 2022
@MicroTed
Merge pull request #2 from grantfirl/feature/nsslmicro_gjf
a2a7f8b 
Minor changes to prepare for merge
BinLiu-NOAA pushed a commit that referenced this pull request Oct 11, 2022
@ChunxiZhang-NOAA
Merge pull request #2 from ChunxiZhang-NOAA/feature/merra2_thompson
9c1943c 
Coupling Merra2 aerosol climatology and GOCART forecasted aerosol with Thompson microphysics
BinLiu-NOAA pushed a commit that referenced this pull request Feb 5, 2024
@lisa-bengtsson
Merge pull request #2 from dustinswales/move_stmt_to_init
791c6d6 
move setting of flag from run to init phase
BinLiu-NOAA pushed a commit that referenced this pull request May 5, 2025
@JiliDong-NOAA
code clean up #2
b2d5032
BinLiu-NOAA pushed a commit that referenced this pull request Jul 28, 2025
@iri01
Merge pull request #2 from noaa-oar-arl/feature/aqm_canopy_new_fix
336447d 
Fix to canopy arrays definitions: add intent
BinLiu-NOAA pushed a commit that referenced this pull request Jan 20, 2026
@uturuncoglu
Merge pull request #2 from grantfirl/feature/inline_sync_gjf
3576382 
Update of CDEPS inline sync without sfc_data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ligiabernardet ligiabernardet ligiabernardet left review comments

@ChunxiZhang-NOAA ChunxiZhang-NOAA ChunxiZhang-NOAA left review comments

@BinLiu-NOAA BinLiu-NOAA BinLiu-NOAA approved these changes

@WeiguoWang-NOAA WeiguoWang-NOAA WeiguoWang-NOAA left review comments

@mzhangw mzhangw Awaiting requested review from mzhangw mzhangw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@climbfuji @mzhangw @ChunxiZhang-NOAA @WeiguoWang-NOAA @BinLiu-NOAA @ligiabernardet @grantfirl