Feature/hafs couplehycom#2
Conversation
…90 introduced 3d04c3.
BinLiu-NOAA
requested review from
DeniseWorthen,
junwang-noaa and
uturuncoglu
danrosen25
left a comment
danrosen25
left a comment
There was a problem hiding this comment.
I tested comparing the output of the feature/hafs_couplehycom to support/HAFS running the NUOPC connector UFSATM-HYCOM configuration.
danrosen25
left a comment
danrosen25
left a comment
There was a problem hiding this comment.
I tested comparing the output of the feature/hafs_couplehycom to support/HAFS running the NUOPC connector UFSATM-HYCOM configuration.
|
@danrosen25 just to clarify. I think that this PR include all the changes that I did previously. It seems that we could delete both |
|
Thanks for the discussion at the end of the call. It's much clearer to me now the purpose of this PR. |
|
@DeniseWorthen yes, that was also helpful for me. Sometimes it is hard to see the whole picture and there might be some issue related with the PR. So, it is always nice to hear your suggestions to make life easier. |
Correct feature/hafs_couplehycom fast-forwards 'feature/hafs_couplehycom_cdeps' after the merge into 'support/HAFS' then we can delete both. |
|
@danrosen25 okay. that is great! |
|
After syncing the ufs-weather-model level's support/HAFS branch with the latest ufs-weahter-model develop branch (as of 01/20/20201), the ufs-weather-model level regression tests passed successfully on Orion with this new version of NEMS. With that, I am merging this feature/hafs_couplehycom branch into the support/HAFS branch. And in the near future, we can initiate a pull request to merge the support/HAFS branch back to the NEMS develop branch. |
…e group ... (NOAA-EMC#106) * Update component_HYCOM.mk to support NAVY HYCOM NUOPC cap. * Pointing machine architecture and parallelization strategy for HYCOM/NUOPC for jet/orion/wcoss * Feature/hafs couplehycom (#2) Merge feature/hafs_couplehycom branch back into support/HAFS branch Preparations for external PIO (Ufuk) *Added CPP -DPIO to wrap calls to pio library *component_CDEPS.mk added to configure CDEPS build *component_CDEPS_DATM.mk added to configure CDEPS_DATM build *component_CDEPS_DOCN.mk added to configure CDEPS_DOCN build *component_CMEPS.mk CMEPS-INSTALL moved, default INTERNAL_PIO_INIT added *component_HYCOM.mk added extra build call to HYCOM model *module_EARTH_GRID_COMP.F90 added FRONT_CDEPS_DATM and FRONT_CDEPS_DOCN, added pio initialization Added diagnostics (Dan) *module_EARTH_GRID_COMP.F90 added connector diagnostics configuration Co-authored-by: Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov> Co-authored-by: Daniel Rosen <daniel.rosen@noaa.gov> * ad capability to handle modelio attribute in nems.configure * add cdeps data ocean support * fix undefined variable issue Co-authored-by: Daniel Rosen <daniel.rosen@noaa.gov> Co-authored-by: Biju Thomas <biju.thomas@noaa.gov> Co-authored-by: Bin.Liu <Bin.Liu@noaa.gov> Co-authored-by: Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov>
5 participants
Merge feature/hafs_couplehycom branch back into support/HAFS branch
Preparations for external PIO (Ufuk)
Added diagnostics (Dan)