Skip to content

Get inner message from exception #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haf merged 2 commits into from
Oct 6, 2019
Merged

Get inner message from exception #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f688ec
Get inner message from exception
MNie Oct 5, 2019
ab3252d
- Remove implementation for TC since it couldn't be tested for now
MNie Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Expecto/Expecto.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,14 @@ module Impl =
let mutable logger = Log.create "Expecto"
let setLogName name = logger <- Log.create name

let rec private exnWithInnerMsg (ex: exn) msg =
let currentMsg =
msg + (sprintf "%s%s" Environment.NewLine (ex.ToString()))
if isNull ex.InnerException then
currentMsg
else
exnWithInnerMsg ex.InnerException currentMsg

type TestResult =
| Passed
| Ignored of string
Expand All @@ -454,7 +462,7 @@ module Impl =
| Passed -> "Passed"
| Ignored reason -> "Ignored: " + reason
| Failed error -> "Failed: " + error
| Error e -> "Exception: " + e.ToString()
| Error e -> "Exception: " + exnWithInnerMsg e ""
member x.tag =
match x with
| Passed -> 0
Expand Down