Get inner message from exception #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haf
reviewed
Oct 6, 2019
haf
reviewed
Oct 6, 2019
haf
reviewed
Oct 6, 2019
Owner
|
I think we should focus on just solving the issue since changing it for the teamcity printer might have unintended consequences unless verified, such as having the message halfed due to the newline; TeamCity parses single lines into its messages. Do we separate out the printing to its own private function for now? |
Owner
|
Thank you for your PR @MNie ! This is what we need :) |
- extract msg function from TestResult - join invocation with base msg
Contributor
Author
|
Owner
|
@MNie Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #348 .
I have 2 questions:
InnerExceptionis right, or we prefer<> null?CC: @haf