Skip to content

Conversation

@auduchinok
Copy link
Contributor

Fixes #336.

@haf
Copy link
Owner

haf commented Aug 20, 2019

Have you validated this on a terminal, so that it doesn't mess up e.g. the console/ANSI escape codes?

@auduchinok
Copy link
Contributor Author

auduchinok commented Aug 20, 2019

Nope, only run the test suite via fake.
Isn't it something that should be covered by the printers (already)?

@haf
Copy link
Owner

haf commented Aug 21, 2019

@auduchinok It is, but I never got around to proving that property in my head, because there's a certain amount of global state when printing (-ansi) to the console singleton. In all likelyhood, it's enough for you to run expecto with itself through its test suite on your terminal and see that it works.

@haf haf merged commit d182de5 into haf:master Aug 21, 2019
@haf
Copy link
Owner

haf commented Aug 21, 2019

@auduchinok thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report duplicate names via printer

2 participants