switch to http for download #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @slhck , thank you for the PR. I'll have a look this week and hopefully merge it. Cheers! |
|
Hi, did you get a chance to look at the PR? |
|
Hey @hadiasghari, I'm just checking in to see about the status of the PR. I'd really appreciate if you could have a look! Let me know if there's anything I can do to help this get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #72 and supports downloading via HTTPS instead of the deprecated and insecure FTP variant.
A minor additional change is that we should not hardcode
/usr/bin/pythonin the shebang lines but instead let the enironment decide which Python version to use.