Skip to content

Impr/file detection #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

quamejnr
Copy link
Contributor

@quamejnr quamejnr commented Aug 4, 2023

  1. Searches directory recursively

This resolves an issue where files are not automatically detected if all your files are inside folders

  1. Don't initialize git

Avoid automatically initializing git in repository which might lead to git being initialized when goignore binary file is just needed to generate gitignore files. For example, I might have goignore binary file in my utilities folder to generate gitignore files to copy and paste inside my projects. Don't want to initialize git in that folder just to generate a gitignore file.

  1. Run without installing package.

Update README.md file with instructions allowing users to use the goignore in other non-golang projects

Copy link
Owner

@hacktivist123 hacktivist123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good to me. Just a tiny change

Thank you so much for the excellent work.

@@ -48,17 +48,6 @@ var newCmd = &cobra.Command{
}
}

// Check if .git repo exists, if not initialize it
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing this, just comment it out because as a future feature, I want to give users the option to choose between having a git repo initialize or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed changes

Copy link
Owner

@hacktivist123 hacktivist123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else LGTM, just one small change.

Thanks for the excellent work.

@quamejnr
Copy link
Contributor Author

quamejnr commented Aug 4, 2023

You are welcome

@hacktivist123 hacktivist123 self-requested a review August 4, 2023 17:34
@hacktivist123 hacktivist123 merged commit 9d8f81f into hacktivist123:main Aug 4, 2023
@quamejnr quamejnr deleted the impr/file-detection branch August 4, 2023 18:42
hacktivist123 added a commit that referenced this pull request Aug 5, 2023
* Update README.md

* change package name

* change package name

* add license

* Update README.md

* fix error where installation failed due to incorrect module path

* fix

* update readme

* Update README.md

* add env files

* Improve language detection code and add new gitignore files

* update .gitignore

* another fix

* update and lint main.go (#6)

* Fix binary error (#7)

* update and lint main.go

* implement fix for error where goignore cannot find the gitignore templates file

* test binary

* Create github action (#11)

* Impr/file detection (#9)

* update README with todo list for next release

* fix tasks list syntax (#13)

* scrap auto flag (#16)

* scrap auto flag, make auto-detect my default and implement logic for error if a language isn't supported

* update README with new instructions

* Goreleaser configuration  (#17)

* feat: goreleaser configuration

* Change go version for goreleaser

* Update .goreleaser.yaml

---------

Co-authored-by: Shedrack akintayo <[email protected]>

* Update release.yml (#18)

* added fix for language detection (#20)

* feat: implemented a function(and a flag) to initialize an empty git repository (#21)

* feat: implemented a function(and a flag) to initialize an empty git repository

* chore: mark todo to allow users init git repo as done

* update README with new command

* update README structure (#24)

* Update go.yml (#26)

* Refactored functions and added tests (#22)

* Refactored functions and added tests

* add filesystem

* Update main.go

update afero.walk() arguments

---------

Co-authored-by: Shedrack akintayo <[email protected]>

* update gh actions

* Update README.md

* Update README.md

---------

Co-authored-by: Kwame Akuamoah-Boateng <[email protected]>
Co-authored-by: Daniel Adeboye <[email protected]>
Co-authored-by: Khagan Chuks <[email protected]>
Co-authored-by: Nonso Unachukwu <[email protected]>
hacktivist123 pushed a commit that referenced this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants