-
Notifications
You must be signed in to change notification settings - Fork 6
Impr/file detection #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impr/file detection #9
Conversation
quamejnr
commented
Aug 4, 2023
- Searches directory recursively
- Don't initialize git
- Run without installing package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good to me. Just a tiny change
Thank you so much for the excellent work.
@@ -48,17 +48,6 @@ var newCmd = &cobra.Command{ | |||
} | |||
} | |||
|
|||
// Check if .git repo exists, if not initialize it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of removing this, just comment it out because as a future feature, I want to give users the option to choose between having a git repo initialize or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything else LGTM, just one small change.
Thanks for the excellent work.
You are welcome |
* Update README.md * change package name * change package name * add license * Update README.md * fix error where installation failed due to incorrect module path * fix * update readme * Update README.md * add env files * Improve language detection code and add new gitignore files * update .gitignore * another fix * update and lint main.go (#6) * Fix binary error (#7) * update and lint main.go * implement fix for error where goignore cannot find the gitignore templates file * test binary * Create github action (#11) * Impr/file detection (#9) * update README with todo list for next release * fix tasks list syntax (#13) * scrap auto flag (#16) * scrap auto flag, make auto-detect my default and implement logic for error if a language isn't supported * update README with new instructions * Goreleaser configuration (#17) * feat: goreleaser configuration * Change go version for goreleaser * Update .goreleaser.yaml --------- Co-authored-by: Shedrack akintayo <[email protected]> * Update release.yml (#18) * added fix for language detection (#20) * feat: implemented a function(and a flag) to initialize an empty git repository (#21) * feat: implemented a function(and a flag) to initialize an empty git repository * chore: mark todo to allow users init git repo as done * update README with new command * update README structure (#24) * Update go.yml (#26) * Refactored functions and added tests (#22) * Refactored functions and added tests * add filesystem * Update main.go update afero.walk() arguments --------- Co-authored-by: Shedrack akintayo <[email protected]> * update gh actions * Update README.md * Update README.md --------- Co-authored-by: Kwame Akuamoah-Boateng <[email protected]> Co-authored-by: Daniel Adeboye <[email protected]> Co-authored-by: Khagan Chuks <[email protected]> Co-authored-by: Nonso Unachukwu <[email protected]>