Modularize module for easier maintenance and future enhancements #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved command into separate files - Moved utilities into utils file - Moved commonly applies command into utilities - Added ImageMagick 7 support Other Changes - Fixed bug with ImageMagick 7 - General cleanup of code - Added package-lock.json - Added copyright header to all files - Added bumped version
|
@hacksparrow I have made some major changes to this module. Would like you to review this PR before I pull the trigger. |
|
@mrkmg looking great! Please go ahead with the merge. |
hacksparrow
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of entire module
Other Changes