Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev improvements #1214

Merged
merged 13 commits into from
Sep 8, 2020
Merged

Dev improvements #1214

merged 13 commits into from
Sep 8, 2020

Conversation

jaronheard
Copy link
Contributor

@jaronheard jaronheard commented Sep 5, 2020 •
edited
Loading

  • Upgraded node (10.15.3 -> 12.16.1), yarn (1.21.1 -> 1.22.5), webpack (sync on 4.44.1), to latest stable versions, and resolved issues and warnings due to node upgrade.
  • Regenerated lockfile using latest node and yarn
  • Added a watch script to component library packages and at package root that you can run to rebuild components automatically while you're running other packages
  • Added a fast refresh option using react-refresh-webpack-plugin to dev-server for development based off of the REFRESH_MODE environment variable. Not making this a default as it's still a bit buggy, but it will be an officially supported part of React in the future.

Resolves #1175

@jaronheard jaronheard marked this pull request as ready for review September 5, 2020 21:42
@jaronheard jaronheard mentioned this pull request Sep 6, 2020
Closed
@jaronheard jaronheard assigned ghost Sep 6, 2020
@jaronheard jaronheard mentioned this pull request Sep 6, 2020
Closed
3 tasks
ghost
ghost approved these changes Sep 7, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled, updated nvm & did new package install, ran 2018 package locally and appears to work just fine!

@jaronheard jaronheard merged commit 6d52171 into master Sep 8, 2020
@jaronheard jaronheard deleted the dev-improvements branch September 8, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Yarn for security
1 participant
@jaronheard