Support etc optional chainid #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackmod
force-pushed
the
support-etc-optional-chainid
branch
3 times, most recently
from
3ceb44a to
d7d3ecf
Compare
8 tasks
…on into ledger-support
hackmod
force-pushed
the
support-etc-optional-chainid
branch
from
d7d3ecf to
3c3e96c
Compare
Restore multiple consecutive accounts with balances.
Add Ledger hardware wallet support
Two important notes: 1. The time it takes to download is negligble compared to e2e test runs 2. Since we cannot use environment variables in CircleCI cache keys we can't cache the download correctly and have it update when we switch firefox versions—this isn't the end of the world because of point 1
CircleCI no longer allows external PR builds to save caches so jobs that depend on cached data from a upstream job will no longer get the files they need. This change replaces our usages of caches for passing data downstream with workspaces, which appear to be the more correct feature to use. References: - https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs - https://circleci.com/blog/deep-diving-into-circleci-workspaces/
Update CircleCI configuration to use workspaces instead of caches
hackmod
force-pushed
the
support-etc-optional-chainid
branch
from
3c3e96c to
1ad9043
Compare
Update logo wordmark
* fixed custom Rpc form to support optional chainid * experimental ETC support added [fixed conflict 8/16]
* etc logo added * price info from https://min-api.cryptocompare.com/
* fixup for testnet faucet
* rename frequentRpcList to frequentRpcListDetail to prevent compatible issue * increase frequentRpcList length by 1
hackmod
force-pushed
the
support-etc-optional-chainid
branch
from
1ad9043 to
5825556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.