Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency resolving with prom-client v12 #1834

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented Dec 26, 2023

[email protected] has prom-client@11 as peer dependency

https://github.com/PayU/prometheus-api-metrics/blob/4e67fd1e2ba90074b1da75c246a849f59f8eda5f/package.json#L41-L43

The docker build failed because of this dependency issue

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/prom-client
npm ERR!   prom-client@"^12.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer prom-client@"11.x" from [email protected]
npm ERR! node_modules/prometheus-api-metrics
npm ERR!   prometheus-api-metrics@"^2.2.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@Yukaii Yukaii force-pushed the bugfix/fix-dependency-conflicting-with-prom-client branch 3 times, most recently from be9c5e3 to 8c4f249 Compare December 26, 2023 08:49
@Yukaii Yukaii modified the milestones: Next, 2.5.0 Dec 26, 2023
@Yukaii Yukaii force-pushed the bugfix/fix-dependency-conflicting-with-prom-client branch 2 times, most recently from e777e72 to d653a5b Compare December 26, 2023 09:23
@Yukaii Yukaii modified the milestones: 2.5.0, Next, 2.5.1 Dec 29, 2023
@Yukaii
Copy link
Member Author

Yukaii commented Dec 29, 2023

The image was built sucessfully

スクリーンショット 2023-12-29 夕方4 53 45

[email protected] has prom-client@11 as peer dependency

Signed-off-by: Yukai Huang <[email protected]>
@Yukaii Yukaii force-pushed the bugfix/fix-dependency-conflicting-with-prom-client branch from d653a5b to 97eb1f2 Compare December 29, 2023 09:00
@Yukaii Yukaii merged commit 7257ac6 into develop Jan 2, 2024
7 checks passed
@Yukaii Yukaii deleted the bugfix/fix-dependency-conflicting-with-prom-client branch January 2, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant