Fix S3 client config passing for image upload #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref issue: aws/aws-sdk-js-v3#1396 Signed-off-by: Max Wu <[email protected]>
a60814billy
approved these changes
May 19, 2021
|
Hi there, I'm facing the same issue as #1572. I noticed your fix doesn't make it into the latest release. |
|
@jackycute Thanks for the quick response! I'll look forward to the next release. |
|
Btw. I'm facing another TLS connection issue, but I'll create an issue for that. |
Merged
edgarogh
pushed a commit
to WartaPoirier-corp/codimd
that referenced
this pull request
Jun 7, 2022
Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1572 which not passing config to S3 client properly
ref issue: aws/aws-sdk-js-v3#1396
Signed-off-by: Max Wu [email protected]