Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
the oauth2 provider is missing a basic authorization concept. That's why I propose this PR. The implementation is based on the saml provider:
codimd/lib/auth/saml/index.js
Line 23 in 381b3ff
CMD_OAUTH2_ROLES_CLAIM
.id
, which overridesuserProfileUsernameAttr
, if set:userProfileIdAttr
.I introduced that attribute because a
username
might be unique, but nevertheless it is also prone to change. Imagine usernames which are built from parts of your first and lastname, either automatically or due to company guidelines. If people want to change their name, because of marriage or whatever reason else, the username no longer provides a stable ID. Thus, it's not only uniqueness but also immutability, which makes a good ID, e.g. auuid
provided by another claimExample configuration
Please note: I am no JavaScript developer. So, the code style of my modifications is merely an educated guess. 🙂