Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better redirection after a successful login #1609

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Better redirection after a successful login #1609

merged 1 commit into from
Apr 16, 2021

Conversation

mic4ael
Copy link
Contributor

@mic4ael mic4ael commented Oct 2, 2020

When:

  1. you are not logged in
  2. and you try to view a private note

Then:

  1. you are redirected to the home page and asked to log in
  2. once you log in you are not redirected to the note

This PR fixes this situation and redirects user to a note on a successful login.

@giacomd
Copy link

giacomd commented Oct 17, 2020

Working great on our instance managed by @mic4ael !

@mic4ael
Copy link
Contributor Author

mic4ael commented Mar 22, 2021

any update on this?

@Yukaii Yukaii merged commit bf5325b into hackmdio:develop Apr 16, 2021
@jackycute jackycute mentioned this pull request May 13, 2021
Merged
@jackycute jackycute mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackycute jackycute jackycute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mic4ael @giacomd @jackycute @Yukaii