Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Muyin Zheng in home-unite-us.md #7427

Merged

Conversation

izma-mujeeb
Copy link
Member

Fixes #7190

What changes did you make?

  • Using spaces, I added a variable named github-handle to hold Muyin Zheng's github handle

Why did you make the changes (we will use this info to test)?

  • The reason why I had to add a github-handle variable was because eventually this variable is going to replace the github and picture variables for each member in the leadership team. By adding this variable, I am reducing redundancy and ensuring the code in the project file is efficient.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izma-mujeeb-add-github-handle-7190 gh-pages
git pull https://github.com/izma-mujeeb/website.git add-github-handle-7190

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 10, 2024
@FamousHero FamousHero self-requested a review September 10, 2024 05:16
@FamousHero
Copy link
Member

i. Availability: Mon-Fri: 5pm-6pm
ii. ETA: EOD 9/11/24

@tamara-snyder
Copy link
Member

Review ETA: End of day 9/10/2024
Availability: Evenings

Copy link
Member

@tamara-snyder tamara-snyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I see you added the github-handle line using spaces and the appearance of the website hasn't changed. Well done :)

Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @izma-mujeeb, every looks great!
branch name is descriptive and has issue # in it. Clear and concise change description and reason.
Keep up the good work!

@Thinking-Panda
Copy link
Member

@izma-mujeeb Nice work on this issue!

@Thinking-Panda Thinking-Panda merged commit 9f8231a into hackforla:gh-pages Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Muyin Zheng in home-unite-us.md
4 participants