replace deprecated egrep with grep -e to suppress warning #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerb9
reviewed
May 10, 2024
| @@ -540,7 +540,7 @@ inittermkey() { | |||
|
|
|||
| # To be valid, we must enable terminal application mode key sequences. | |||
| if tput smkx; then | |||
| for k in $(infocmp -L1 | egrep 'key_|cursor_'); do | |||
| for k in $(infocmp -L1 | grep -e 'key_|cursor_'); do | |||
There was a problem hiding this comment.
Thank you, but 'grep -e' is not equivalent to 'egrep'. POSIX wants everyone to type grep -E, I believe.
|
Thank you for the report. I believe I have fixed it in the latest version. |
|
Oh my mistake, just trying to quick fix. I’ll update when I can ✌️
Sent from [Proton Mail](https://proton.me/mail/home) for iOS
…On Fri, May 10, 2024 at 2:09 AM, hackerb9 ***@***.***(mailto:On Fri, May 10, 2024 at 2:09 AM, hackerb9 <<a href=)> wrote:
@hackerb9 commented on this pull request.
---------------------------------------------------------------
In [vv](#8 (comment)):
> @@ -540,7 +540,7 @@ inittermkey() {
# To be valid, we must enable terminal application mode key sequences.
if tput smkx; then
- for k in $(infocmp -L1 | egrep 'key_|cursor_'); do
+ for k in $(infocmp -L1 | grep -e 'key_|cursor_'); do
Thank you, but 'grep -e' is not equivalent to 'egrep'. POSIX wants everyone to type grep -E, I believe.
—
Reply to this email directly, [view it on GitHub](#8 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ALKWKQUIORPMRTEM2QXJMJLZBRQCNAVCNFSM6AAAAABHJOECEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBZGMYTOMZQHE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
No need to update. I've fixed it. Thanks again for the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egrep is deprecated