Skip to content

fix(approval): auto-approve commands when alwaysAllowExecute=true without allowlist #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hacker-b2k merged 1 commit into from
Jun 24, 2026
Merged

fix(approval): auto-approve commands when alwaysAllowExecute=true without allowlist #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/core/auto-approval/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,13 @@ export async function checkAutoApproval({
}

if (state.alwaysAllowExecute === true) {
const decision = getCommandDecision(text, state.allowedCommands || [], state.deniedCommands || [])
// When alwaysAllowExecute is ON but no allowedCommands are configured,
// treat it as wildcard "*" — auto-approve ALL commands (except denied).
// This makes BRRR mode work correctly: toggling alwaysAllowExecute on
// should auto-approve commands without requiring manual allowlist setup.
// Denied commands still take priority via the denylist check below.
const effectiveAllowed = state.allowedCommands?.length ? state.allowedCommands : ["*"]
const decision = getCommandDecision(text, effectiveAllowed, state.deniedCommands || [])

if (decision === "auto_approve") {
return { decision: "approve" }
Expand Down