adding clippy for windows #1027
Conversation
mwrock
requested review from
baumanj,
chefsalim,
eeyun and
raskchanky
as code owners
There was a problem hiding this comment.
Assuming habitat-sh/habitat#6430 works out, I think we should make these small tweaks here. Aside from that, it looks great!
mwrock
force-pushed
the
clippy
branch
2 times, most recently
from
b3df794 to
5fd805a
Compare
test/allowed_lints.txt
Outdated
| clippy::module_inception | ||
| clippy::new_ret_no_self | ||
| clippy::new_without_default | ||
| clippy::redundant_closure |
There was a problem hiding this comment.
I'm still not comfortable with moving this to allowed. I know rust-lang/rust-clippy#3071 exists, but I've yet to see it flag something in our code that can't be fixed, even if the automatic suggestion isn't a correct fix. And for anything we decide we really prefer with an explicit closure, we can #[allow(…)] it.
I'm ok with moving redundant_closure to lints_to_fix, but I still find this lint valuable, and I imagine issue 3071 will be fixed at some point.
There was a problem hiding this comment.
Moving to lints_to_fix would be ok as well. Given that the clippy default is warn not deny, and there are known issues, it's also reasonable to just allow it and move on.
Signed-off-by: mwrock <[email protected]>
Resolves habitat-sh/habitat#6213
Signed-off-by: mwrock [email protected]